Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Unpin and update @vanilla-extract/webpack-plugin #273

Closed
wants to merge 1 commit into from

Conversation

askoufis
Copy link
Contributor

@askoufis askoufis commented Jan 5, 2023

I think @vanilla-extract/webpack-plugin accidentally became pinned in #269. In addition, @vanilla-extract/babel-plugin was removed in #269, but this requires at least @vanilla-extract/webpack-plugin@2.2.0, so I've updated the version to ^2.2.0.

@askoufis askoufis requested a review from a team as a code owner January 5, 2023 05:23
@changeset-bot
Copy link

changeset-bot bot commented Jan 5, 2023

🦋 Changeset detected

Latest commit: 55fef07

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package
Name Type
playroom Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@askoufis askoufis changed the title Unpin and update @vanilla-extract/webpack-plugin Unpin and update @vanilla-extract/webpack-plugin Jan 5, 2023
@askoufis
Copy link
Contributor Author

askoufis commented Jan 6, 2023

Seems like there was a good reason to pin the dependency.

Looks like similar issues have been reported in the VE repo.

This is what occurs when starting the basic fixture:
image

@askoufis askoufis closed this Jan 6, 2023
@askoufis askoufis deleted the unpin-ve-webpack-plugin branch February 19, 2024 03:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants