Add "Toggle comment" key command #321
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
🦋 Changeset detectedLatest commit: b35c80e The changes in this PR will be included in the next version bump. This PR includes changesets to release 1 package
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
Selection area is incorrect
askoufis
reviewed
Feb 21, 2024
This reverts commit ce107c3. # Conflicts: # package.json
Co-authored-by: Adam Skoufis <askoufis@users.noreply.github.com>
askoufis
reviewed
Feb 22, 2024
Comment on lines
+539
to
+540
| // Todo - (1/2) Solve issue where Ubuntu does not select to the start of line | ||
| // Todo - (2/2) with one trigger of the keybinding |
There was a problem hiding this comment.
Has this been addressed? Is this an ubuntu issue, or a broader linux issue?
There was a problem hiding this comment.
This hasn't been addressed. I'm not 100% sure who the culprit is but by default on the Ubuntu tests, the backwards selection goes up to the opening "//" (not including), whereas macOS selection goes to the very start of the line.
askoufis
reviewed
Feb 22, 2024
askoufis
approved these changes
Feb 23, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Solving issue #295.
Adds keybinding Cmd + / (or, on Windows, Ctrl + /) to toggle comment syntax for the currently selected code.
NB: the additional cypress tests make GitHub actions take a fair bit longer, but will look to fix that in a follow-up PR.