Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Replace concurrently dev dep with pnpm run #339

Merged
merged 2 commits into from
Mar 5, 2024
Merged

Replace concurrently dev dep with pnpm run #339

merged 2 commits into from
Mar 5, 2024

Conversation

askoufis
Copy link
Contributor

@askoufis askoufis commented Mar 5, 2024 •
edited
Loading

PNPM supports using regexes to run multiple scripts at once, so we can use that instead of concurrently.

@askoufis askoufis requested a review from a team as a code owner March 5, 2024 00:07
@changeset-bot changeset-bot
Copy link

changeset-bot bot commented Mar 5, 2024 •
edited
Loading

⚠️ No Changeset found

Latest commit: 60240c6

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@askoufis askoufis merged commit 83b73b3 into master Mar 5, 2024
6 checks passed
@askoufis askoufis deleted the remove-concurrently branch March 5, 2024 00:43
felixhabib added a commit that referenced this pull request Mar 6, 2024
@felixhabib
Revert "Replace concurrently dev dep with pnpm run (#339)"
49ba9a7 
This reverts commit 83b73b3.
felixhabib added a commit that referenced this pull request Mar 6, 2024
@felixhabib
Revert "Replace concurrently dev dep with pnpm run (#339)" to fix…
9208310 
… Cypress locally (#342)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@michaeltaranto michaeltaranto michaeltaranto approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@askoufis @michaeltaranto