Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Revert "Replace concurrently dev dep with pnpm run (#339)" to fix Cypress locally #342

Merged
merged 1 commit into from
Mar 6, 2024

Conversation

felixhabib
Copy link
Contributor

@felixhabib felixhabib commented Mar 6, 2024

This reverts commit 83b73b3.

Since this change, running Cypress locally will consistently fail in different ways.
After reverting, Cypress consistently passes for me.

Copy link

changeset-bot bot commented Mar 6, 2024

⚠️ No Changeset found

Latest commit: 49ba9a7

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@felixhabib felixhabib changed the title Revert "Replace concurrently dev dep with pnpm run (#339)" to fix local Cypress tests locally Revert "Replace concurrently dev dep with pnpm run (#339)" to fix Cypress tests locally Mar 6, 2024
@felixhabib felixhabib changed the title Revert "Replace concurrently dev dep with pnpm run (#339)" to fix Cypress tests locally Revert "Replace concurrently dev dep with pnpm run (#339)" to fix Cypress locally Mar 6, 2024
@felixhabib felixhabib marked this pull request as ready for review March 6, 2024 04:47
@felixhabib felixhabib requested a review from a team as a code owner March 6, 2024 04:47
@felixhabib felixhabib merged commit 9208310 into master Mar 6, 2024
6 checks passed
@felixhabib felixhabib deleted the fix-local-cypress branch March 6, 2024 04:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants