-
Notifications
You must be signed in to change notification settings - Fork 1
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Import rynovate into the renovate-config-seek namespace #21
base: master
Are you sure you want to change the base?
Conversation
default.json
Outdated
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
- Do we intend to take over the
default
here? An alternative may be to reroutegithub>seek-oss/rynovate
to a named preset likegithub>seek-oss/renovate-config-seek:recommended
. - Existing
renovate-config-seek
consumers go via npm package, so while we don't need to reservedefault
, there is an open question about where we migrate them to (default
,third-party-major
, a separate preset that retains priorrenovate-config-seek
behaviour?)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
- No strong opinions personally
- There are very few consumers and they'll need to actively migrate away. That doesn't answer your question. I know Jahred was keen on having a preset that has similar functionality to the existing, which I'm open to doing in this PR or a follow up
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I know Jahred was keen on having a preset that has similar functionality to the existing
I'm keen to interrogate this use case over an alternative like third-party-major
. When is it acceptable for a system owner to ignore major revisions of their third-party dependencies from a tech health perspective?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I hadn't really looked at third-party-major before but it seems like a fairly reasonable alternative to the old renovate-seek-config, to me (majors + seek package minor/patches)
@@ -1,85 +1,21 @@ | |||
{ | |||
"name": "renovate-config-seek", |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I assume this means that we are moving from a versioned npm model (repos must explicitly upgrade to the new package version) to a GitHub default branch model (repos automatically receive merged changes). I like this change but is it contentious to anyone else?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
They're deprecated, so I hope not: https://docs.renovatebot.com/config-presets/#npm-hosted-presets
@@ -0,0 +1 @@ | |||
* @seek-oss/indirect |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Reminder to change this
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Open to changing this in the PR if we can come to an agreement
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
What about:
* @seek-oss/indirect | |
* @seek-oss/sig-backend-tooling @seek-oss/sku-maintainers |
(and adjusting the admin access as per ^)
Co-authored-by: Ryan Ling <ryan@outlook.com.au>
This requires workshopping, but keen for feedback and direction.
As a short summary of conversations,
rynovate
has evolved to be the defacto standard across SEEK and it would be good to promote that to the renovate-config-seek namespace.There is more work to do here before widespread usage, but getting this initial diff in will help conversations