Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(jest): Add testURL Jest config #151

Merged
merged 2 commits into from
Jul 29, 2018
Merged

Conversation

mbfisher
Copy link
Contributor

Preemptive defence against jestjs/jest#6766.

@markdalgleish
Copy link
Member

Nice one 👏

The scope for this should be fix so it triggers a release.

@mbfisher
Copy link
Contributor Author

Why would we release changes to internal test config?

Should we be adding this to config/jest/jestConfig.js do you think? That would be a fix.

@markdalgleish
Copy link
Member

Oh, sorry, I misunderstood this PR. I assumed you were fixing this for consumers. Yeah, we should probably do that too.

@mbfisher mbfisher changed the title build(jest): Add testURL Jest config fix(jest): Add testURL Jest config Jul 29, 2018
@mbfisher mbfisher merged commit e83b29b into seek-oss:master Jul 29, 2018
@mbfisher mbfisher deleted the fix-jest branch July 29, 2018 23:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants