Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

docs: Update server rendering example #386

Merged
merged 1 commit into from
Jul 12, 2019
Merged

docs: Update server rendering example #386

merged 1 commit into from
Jul 12, 2019

Conversation

michaeltaranto
Copy link
Contributor

Updating the server rendering docs to cover:

  • Be valid JS and return the object literal
  • Handle skuParams in the renderCallback

@michaeltaranto michaeltaranto requested a review from a team as a code owner July 12, 2019 01:13
@michaeltaranto michaeltaranto merged commit 4fa2e02 into master Jul 12, 2019
@michaeltaranto michaeltaranto deleted the server-render-docs branch July 12, 2019 01:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@markdalgleish markdalgleish markdalgleish approved these changes

@mattcompiles mattcompiles mattcompiles approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@michaeltaranto @markdalgleish @mattcompiles