Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add .npmrc mounts #1434

Merged
merged 1 commit into from
Feb 7, 2024
Merged

add .npmrc mounts #1434

merged 1 commit into from
Feb 7, 2024

Conversation

samchungy
Copy link
Contributor

Looks like pnpm fetch reads the .npmrc for settings and outputs a publicHoistPattern in node_modules/.modules.yaml

image

As a result, when we go to run pnpm install --offline it fails silently and asks if we would like to destroy node_modules

image

This results in skuba not being properly hoisted.

@samchungy samchungy requested review from a team as code owners February 7, 2024 02:15
Copy link

changeset-bot bot commented Feb 7, 2024

⚠️ No Changeset found

Latest commit: 837242c

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

Copy link
Contributor

@AaronMoat AaronMoat left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Dunno what I'm doing with mounts but seems fine. I don't think we need a changeset as it'd be largely redundant?

@samchungy samchungy merged commit 634350b into master Feb 7, 2024
18 checks passed
@samchungy samchungy deleted the npmrc branch February 7, 2024 02:38
@samchungy
Copy link
Contributor Author

Dunno what I'm doing with mounts but seems fine. I don't think we need a changeset as it'd be largely redundant?

Yeah we haven't release yet, so it should be okay

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants