Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

template: Exclude DOM type definitions by default #822

Merged
merged 4 commits into from
Mar 30, 2022
Merged

Conversation

72636c
Copy link
Member

@72636c 72636c commented Mar 30, 2022

No description provided.

@72636c 72636c requested review from a team as code owners March 30, 2022 14:03
This works in Node.js but annoyingly sits under the DOM type defs.
@changeset-bot
Copy link

changeset-bot bot commented Mar 30, 2022

馃 Changeset detected

Latest commit: ec1607b

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package
Name Type
skuba Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

Copy link
Contributor

@etaoins etaoins left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

馃挕

@72636c 72636c enabled auto-merge (squash) March 30, 2022 21:52
@72636c 72636c merged commit 54f5861 into master Mar 30, 2022
@72636c 72636c deleted the no-dom-type-defs branch March 30, 2022 21:52
@seek-oss-ci seek-oss-ci mentioned this pull request Mar 30, 2022
72636c added a commit to seek-oss/skuba-dive that referenced this pull request Mar 31, 2022
72636c added a commit to seek-oss/eslint-config-skuba that referenced this pull request Mar 31, 2022
72636c added a commit to seek-oss/skuba-dive that referenced this pull request Mar 31, 2022
72636c added a commit to seek-oss/eslint-config-skuba that referenced this pull request Mar 31, 2022
72636c added a commit to seek-oss/datadog-custom-metrics that referenced this pull request Apr 6, 2022
72636c added a commit to seek-oss/fake-hr that referenced this pull request Apr 6, 2022
72636c added a commit to seek-oss/koala that referenced this pull request Apr 6, 2022
72636c added a commit to seek-oss/logger that referenced this pull request Apr 6, 2022
72636c added a commit to seek-oss/wingman that referenced this pull request Apr 6, 2022
72636c added a commit to seek-oss/datadog-custom-metrics that referenced this pull request Apr 6, 2022
72636c added a commit to seek-oss/koala that referenced this pull request Apr 6, 2022
72636c added a commit to seek-oss/wingman that referenced this pull request Apr 6, 2022
72636c added a commit to seek-oss/fake-hr that referenced this pull request Apr 6, 2022
72636c added a commit to seek-oss/logger that referenced this pull request Apr 7, 2022
72636c added a commit to seek-oss/logger that referenced this pull request Apr 7, 2022
* deps: skuba 4.2.0

* Exclude DOM type definitions

Per seek-oss/skuba#822.

* Remove unused directive

Co-authored-by: Renovate Bot <bot@renovateapp.com>
Co-authored-by: Ryan Ling <ryan@outlook.com.au>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants