Bugfixes Sample Experiment Templates #1884
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Collaborator
kdp-cloud
commented
May 16, 2024
•
kdp-cloud
commented
- Makes sure users cannot create new templates from scratch. Closes Remove GUI to create ISA-compliant Templates from scratch #1757
- Template behavior is now different from Sample type behavior. Some limitations of the Sample Type are not applied on templates anymore:
- Template attributes can be removed when inherrited from another template
- All fields (except ISA tag) are editable again for inherrited attributes
- Closes Reduce amounts of checks when creating a template #1758
- Users can only create templates and link them to projects they administer instead of all projects they are member of. Closes Template creation if non-administrator #1880
- Users that are not project admins but have editing rights for studies and assays, will also be able to edit its sample type as long as it's a project member. Closes Sample type permissions for project members #1890
…tton when an existing template is shown.
This was
linked to
issues
May 16, 2024
… can be set but not changed.
stuzart
requested changes
May 29, 2024
| @@ -54,6 +54,7 @@ def with_current_user | |||
| def current_person | |||
| current_user.try(:person) | |||
| end | |||
| helper_method :current_person | |||
There was a problem hiding this comment.
this should be moved to the top of the file, next to helper :all
There was a problem hiding this comment.
I grouped all helper methods together.
stuzart
approved these changes
May 29, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.