-
Notifications
You must be signed in to change notification settings - Fork 4
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add a writer_kwargs argument to MDAReporter and speed up testing #7
Conversation
…t have to reinstantiate the simulation with each test and SIGNIFICANTLY speeds up the test suite.
Would love a look from @richardjgowers or @sef43 when y'all have time! I think the changes are pretty innocuous and would help me solve a downstream use case. |
Thanks for the contribution!, can this please be re-done without the formatting changes please? The formating change should be a seperate PR. |
Are you opened to the formatting changes? I opened a PR #8 with just the Black formatting. If possible, I'd like to merge that and then reopen this PR so I don't have to sort out the logic from formatting changes. (A little lazy I admit.) |
Currently yes I am against the formatting changes to any of the existing files. The current formatting follows the openmm formatting for Reporter classes. There is no reason to deviate from this.
As you point out here the key issue is that the unnecessary formatting changes obscure the functional changes to the code. I think MDAnalysis does not allow black formatting of existing code, only new code, for this reason. |
Fair enough, I understand the desire to avoid black and stay compatible with upstream formatting. I added a new PR #9 that implements the testing and kwargs changes without the black formatting. |
Fixes #6
Changes made in this Pull Request:
PR Checklist