fix: allow setting anonymousId #799
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
LGTM, but probably needs another set of eyes |
fathyb
reviewed
Nov 29, 2018
AnalyticsTests/TrackingTests.swift
Outdated
| @@ -36,6 +36,20 @@ class TrackingTests: QuickSpec { | |||
| expect(passthrough.lastContext?.eventType) == SEGEventType.identify | |||
| let identify = passthrough.lastContext?.payload as? SEGIdentifyPayload | |||
| expect(identify?.userId) == "testUserId1" | |||
| expect(identify?.anonymousId) == nil | |||
There was a problem hiding this comment.
You need to use the beNil matcher to match nil:
expect(identify?.anonymousId).to(beNil())The tests are breaking because you match an Optional with a pointer (nil? == nil)
Historically, the iOS library has allowed setting a custom anonymous identifier (#485). During adding middlewares, a bug was introduced which started ignoring the anonymousId option. This fixes the bug and adds a test to validate the fix. This was also tested in the example app end to end and I've verified that events show up with the custom anonymousId. Test snipet: ``` [[SEGAnalytics sharedAnalytics] identify:@"Prateek" traits:nil options: @{ @"anonymousId":@"test_anonymousId" }]; ``` Event in debugger: https://cloudup.com/cFyVH4NPR_f Subsequent events will automatically attach the new anonymous ID https://cloudup.com/cK-i_SCbwsN
f2prateek
force-pushed
the
allow-setting-anonymousId
branch
from
aa9fb47
to
0e98d4a
Compare
fathyb
approved these changes
Nov 29, 2018
Serheo
pushed a commit
to fubotv/analytics-ios
that referenced
this pull request
Aug 15, 2019
Historically, the iOS library has allowed setting a custom anonymous identifier (segmentio#485). During adding middlewares, a bug was introduced which started ignoring the anonymousId option. This fixes the bug and adds a test to validate the fix. This was also tested in the example app end to end and I've verified that events show up with the custom anonymousId. Test snipet: ``` [[SEGAnalytics sharedAnalytics] identify:@"Prateek" traits:nil options: @{ @"anonymousId":@"test_anonymousId" }]; ``` Event in debugger: https://cloudup.com/cFyVH4NPR_f Subsequent events will automatically attach the new anonymous ID https://cloudup.com/cK-i_SCbwsN
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Historically, the iOS library has allowed setting a custom anonymous identifier (#485).
During adding middlewares, a bug was introduced which started ignoring the anonymousId option.
This fixes the bug and adds a test to validate the fix. This was also tested in the example app end to end and I've verified that events show up with the custom anonymousId.
How should this be manually tested?
Test snipet:
Event in debugger: https://cloudup.com/cFyVH4NPR_f
Subsequent events will automatically attach the new anonymous ID https://cloudup.com/cK-i_SCbwsN
Closes #753
What are the relevant tickets?
https://segment.atlassian.net/browse/LIB-266