Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Date objects fail json serialization #92

Merged

Conversation

hadrien
Copy link
Contributor

@hadrien hadrien commented Jan 23, 2017

Fix #91

@alexissmirnov
Copy link

+1

@hadrien
Copy link
Contributor Author

hadrien commented Jan 25, 2017

Who should/can review this @jgershen? Thanks!

@f2prateek
Copy link
Contributor

Sorry for the delay, this looks good to me! Would love to have @jgershen and/or @calvinfo review as well.

@calvinfo
Copy link
Contributor

LGTM! Thanks both of you!

@f2prateek f2prateek merged commit 4c9791d into segmentio:master Jan 25, 2017
@hadrien
Copy link
Contributor Author

hadrien commented Jan 25, 2017

Excellent!
How much time should we expect before release?

Sorry to push forward and thanks a lot for the support!

@f2prateek
Copy link
Contributor

I'll likely br able to release this sometime next week.

@hadrien hadrien deleted the fix/date-objects-fail-json-serialization branch January 30, 2017 19:12
@hadrien
Copy link
Contributor Author

hadrien commented May 8, 2017

Please, can you release the v1.2.7? I am looking forward it ! ;-) Thanks a lot!

@hadrien
Copy link
Contributor Author

hadrien commented May 8, 2017

It is actually released: https://pypi.python.org/pypi/analytics-python/1.2.7

My bad sorry! thanks a lot!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants