Skip to content
This repository has been archived by the owner on May 18, 2021. It is now read-only.

Add Golang 1.11 module files - also resolves 99designs keyring problems on Mac #87

Merged
merged 1 commit into from
Oct 17, 2018

Conversation

beiriannydd
Copy link
Contributor

Fixes this dependency and also as a bonus makes go build work nicely, Mac or Linux (with 1.11)

../../go/pkg/mod/github.com/99designs/keyring@v0.0.0-20180523072454-ccd0779e6f10/keychain.go:39:11: undefined: keychain.NewItem
../../go/pkg/mod/github.com/99designs/keyring@v0.0.0-20180523072454-ccd0779e6f10/keychain.go:40:20: undefined: keychain.SecClassGenericPassword
../../go/pkg/mod/github.com/99designs/keyring@v0.0.0-20180523072454-ccd0779e6f10/keychain.go:43:22: undefined: keychain.MatchLimitOne
../../go/pkg/mod/github.com/99designs/keyring@v0.0.0-20180523072454-ccd0779e6f10/keychain.go:49:28: undefined: keychain.NewWithPath
../../go/pkg/mod/github.com/99designs/keyring@v0.0.0-20180523072454-ccd0779e6f10/keychain.go:53:18: undefined: keychain.QueryItem
../../go/pkg/mod/github.com/99designs/keyring@v0.0.0-20180523072454-ccd0779e6f10/keychain.go:54:12: undefined: keychain.ErrorItemNotFound
../../go/pkg/mod/github.com/99designs/keyring@v0.0.0-20180523072454-ccd0779e6f10/keychain.go:76:9: undefined: keychain.Keychain
../../go/pkg/mod/github.com/99designs/keyring@v0.0.0-20180523072454-ccd0779e6f10/keychain.go:87:12: undefined: keychain.NewItem
../../go/pkg/mod/github.com/99designs/keyring@v0.0.0-20180523072454-ccd0779e6f10/keychain.go:88:21: undefined: keychain.SecClassGenericPassword
../../go/pkg/mod/github.com/99designs/keyring@v0.0.0-20180523072454-ccd0779e6f10/keychain.go:199:36: undefined: keychain.Keychain
../../go/pkg/mod/github.com/99designs/keyring@v0.0.0-20180523072454-ccd0779e6f10/keychain.go:88:21: too many errors

@nickatsegment
Copy link
Contributor

Thanks for your contribution, @beiriannydd! We recently did a similar thing for one of our other OSS projects segmentio/chamber#144 and this is a great first step. As written, this won't affect the official builds pipeline. I'll cut an issue to get that on the radar.

@nickatsegment nickatsegment self-requested a review October 17, 2018 17:25
@nickatsegment nickatsegment merged commit ba2156e into segmentio:master Oct 17, 2018
@beiriannydd beiriannydd deleted the fix_deps branch October 18, 2018 20:12
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants