Add go modules #144
Merged
Add go modules #144
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Closed
|
I squash-merged this and see that I'm the author on that commit. Not sure the github etiquette here, but @jmcarp if you wanted your name on it, I'm sorry <3 |
|
FYI I wrote up some of our conclusions on Go modules at https://github.com/segmentio/chamber/wiki/Go-Modules |
This was referenced Oct 17, 2018
Add Golang 1.11 module files - also resolves 99designs keyring problems on Mac
segmentio/aws-okta#87
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Combines #123 and #138
This is 90% @jmcarp's work and is based of his PR #123 , but I feel like it'd be faster to get through if I took ownership.