Skip to content

Commit

Permalink
improve list-services performance by increasing page size (#321)
Browse files Browse the repository at this point in the history
Before this change I measured list-services taking 4m8.79s on stage, afterwards it took 1m18.70s. I don't think these numbers are super accurate because of Parameter Store's low rate limits and retries, but I think this will improve `list-services` performance.
  • Loading branch information
cdignam-segment committed Dec 9, 2021
1 parent cb2fbee commit 74789c3
Showing 1 changed file with 2 additions and 0 deletions.
2 changes: 2 additions & 0 deletions store/ssmstore.go
Original file line number Diff line number Diff line change
Expand Up @@ -265,6 +265,7 @@ func (s *SSMStore) ListServices(service string, includeSecretName bool) ([]strin

if s.usePaths {
describeParametersInput = &ssm.DescribeParametersInput{
MaxResults: aws.Int64(50),
ParameterFilters: []*ssm.ParameterStringFilter{
{
Key: aws.String("Name"),
Expand All @@ -275,6 +276,7 @@ func (s *SSMStore) ListServices(service string, includeSecretName bool) ([]strin
}
} else {
describeParametersInput = &ssm.DescribeParametersInput{
MaxResults: aws.Int64(50),
Filters: []*ssm.ParametersFilter{
{
Key: aws.String("Name"),
Expand Down

0 comments on commit 74789c3

Please sign in to comment.