Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[non-prod] Migrate CI builds to GitHub Actions #98

Merged
merged 5 commits into from
Oct 6, 2022

Conversation

wavetylor
Copy link
Contributor

@wavetylor wavetylor commented Oct 5, 2022

We don't need a snyk step anymore because the repo is already configured with the a snyk webhook.

Once approved, I will disable the branch protection requirement for circleci and replace it with the build github action job.

Testing not required.

jobs:
build:
name: Executes a full build
runs-on: ubuntu-latest
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

we're not executing within a golang container anymore, which simplifies the build.

@wavetylor wavetylor marked this pull request as ready for review October 5, 2022 21:41
Copy link
Collaborator

@erikdw erikdw left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:shipit: 🚀

Thanks!!

@wavetylor wavetylor changed the title Migrate CI builds to Github Actions [non-prod] Migrate CI builds to Github Actions Oct 6, 2022
@wavetylor wavetylor merged commit f0224ae into master Oct 6, 2022
@wavetylor wavetylor deleted the tbrennan/config-7-github-actions branch October 6, 2022 12:54
@erikdw erikdw changed the title [non-prod] Migrate CI builds to Github Actions [non-prod] Migrate CI builds to GitHub Actions Nov 14, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants