Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Deferred publishing #38

Open
wants to merge 3 commits into
base: master
Choose a base branch
from
Open

Conversation

seoester
Copy link

@seoester seoester commented Oct 4, 2019

This PR adds deferred publishing functionality. Both the HTTP API and the NSQ TCP API are supported.

Tests for NSQ TCP API are included. This causes (at least) 10 s of stalling during test execution.
I reduced the timeout for the publish -> consume loop from 10 s to 5 s in order to have tighter bounds for the delivery time of deferred messages. If this causes problems in the CI system, the timeout should be increased again.

@vortex14
Copy link

vortex14 commented Jan 31, 2023

@seoester why we didn't answer for your PR ? What mistake you didn't resolve?
Could you resolve your conflict in your PR?

@seoester
Copy link
Author

I think this project is in deep maintenance status, so new features are not a priority.
AFAIU, Segment has moved mostly away from NSQ for message and event delivery (sometimes to Kafka, for special cases to Centrifuge). NSQ itself also isn't developed much anymore.

If you need this PR, my recommendation is to fork segmentio/nsq-go yourself and cherry-pick all required changes on top. Then, you can use the replace directive in your go.mod to use your own fork rather than the upstream repo.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants