This repository has been archived by the owner on Nov 16, 2023. It is now read-only.
Remove exported readers #16
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fixes #5
| @@ -68,7 +68,7 @@ func (tr *Reader) Fork() *Reader { | |||
| // Read implements the io.Reader interface, forwarding the call to the | |||
| // underlying Thrift protocol Reader. | |||
| func (tr *Reader) Read(p []byte) (int, error) { | |||
| debug.Format("thrift: Reader: Read %d", len(p)) | |||
| debug.Format("thrift: Reader: read %d", len(p)) | |||
There was a problem hiding this comment.
Maybe this change is unnecessary?
There was a problem hiding this comment.
Overenthusiastic search&replace
achille-roussel
approved these changes
Oct 9, 2020
DuanWeiFan
pushed a commit
to DuanWeiFan/parquet-go
that referenced
this pull request
Jul 31, 2023
Drop go1.17
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Unexported most exported methods and types. Clean up unused things. Based on #13.
Fixes #5