-
Notifications
You must be signed in to change notification settings - Fork 543
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Deprecate dep in favor of Go Modules #100
Conversation
Hey @khos2ow, happy new year! I'll look into Go Modules and your PR in the next days. Thanks! |
@zimbatm have you tested this PR, including a pipeline run, before you gave your approval? |
@metmajer isn't CircleCI already doing this for us? |
@zimbatm You are correct. I guess I'm just startled that you're giving your approval to a feature that hasn't been commented by the codebase maintainer. |
I was just passing by and happened to look at the PR. I don't think my approval has a lot of weight, except maybe nudge the maintainers? |
@khos2ow I am looking into your PR at the moment, but I am getting errors with the latest version of |
|
Sorry guys, I was AFK for few days! I agree with @zimbatm , generally everyone can approve any PR, but the ones that matter at the end will be the maitainers'. And that's why there's a color coding of approval (grey vs green). @metmajer that's weird. I've tried
and neither failed. but since you already went ahead with #103 it's all good! Thanks. |
One of gometalinter's plugins failed due to unresolvable package dependencies even after |
Hmm, that's strange. I, yet, need to read more about |
I also needed some time to understand the value and impact of Go modules. Since this goes in my spare time, things sometimes take a while. In the future, let's share thoughts in a dedicated Issue before filing a PR (see Contribution Guide). Thanks for another great contribution, @khos2ow! |
Hey @zimbatm! I really don't mind a nudge. Still, there's a difference between nudging and approving someone's work. While @khos2ow PR has been complete and indeed a valuable contribution to this project, we often see things the other way round here as well. Just be cautious with giving approvals, and if it's simply about a nudge, I'd value if you'd drop me a message instead. 👍 |
@zimbatm By the way, we'd value your contributions if you're inclined. There's a couple of open issues, so feel free to have a look and let me know if you have questions! |
Prerequisites
Put an
x
into the box(es) that apply:For more information, see the Contributing Guide.
Description
This pull request deprecates dep in favor of Go Modules.
Issues Resolved
List any existing issues this pull request resolves.
Checklist
Put an
x
into all boxes that apply:Tests
make test
.Documentation
Code Style