Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add Box prop-type for "element type" #51

Merged
merged 1 commit into from
Jan 13, 2020
Merged

Add Box prop-type for "element type" #51

merged 1 commit into from
Jan 13, 2020

Conversation

andycarrell
Copy link
Contributor

From the docs: https://reactjs.org/docs/typechecking-with-proptypes.html

// A React element type (ie. MyComponent).
optionalElementType: PropTypes.elementType,

Addresses segmentio/evergreen#681

@mshwery mshwery merged commit be608b2 into segmentio:master Jan 13, 2020
@tomitrescak
Copy link

Amazing, thanks for the fix, was really annoying! ;)

@andycarrell andycarrell deleted the fix/box-prop-type branch January 17, 2020 21:17
This was referenced Jan 17, 2020
Closed
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mshwery mshwery mshwery approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@andycarrell @tomitrescak @mshwery