Update index.html #20
Conversation
Initial map location automatically updates based on user settings "unique_coordinates" If "unique_coordinates" is set to false the map will initialize on user 0 lat, lng if set to true the map will initialize on "standard_coordinates"
|
@seikur0 I just wanted you to see the html change before I added the PB support. This is my first time with a github project and I didn't realize it would push commits initiated after the pull request was made. |
I hate commas
|
Okay I'll merge this, but I'll change some things after that, I'll comment some of the changes, so you can see why. |
|
|
||
| LAT_C=settings['standard_coordinates']['lat']; | ||
| LNG_C=settings['standard_coordinates']['lng']; | ||
| var centralized=settings['unique_coordinates']; |
There was a problem hiding this comment.
No need to create a new variable here, just use it directly in the next line.
|
I only had a bare minimum of C++ experience with this.It was fun trying to figure out my syntax errors without a compiler telling me where I messed up. I appreciate you showing me better ways to do this. |
|
@seikur0 Also, do you need me to make the changes on my end (or need me to do anything) before you merge this? I'm new to this. |
|
Nope, I'll merge this and immediately update the files then, it's good. |
|
I love how much neater and functional your code looks. The difference in skill is kind of staggering. My only experience with coding comes from cludge jobs like this using messy code until it does what I want it to. |
Initial map location automatically updates based on user settings "unique_coordinates"
If "unique_coordinates" is set to false the map will initialize on user 0 lat, lng
if set to true the map will initialize on "standard_coordinates"
This can probably be better optimized but I just do patch work