Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix tooltip when option is set to 'always' #895

Merged
merged 3 commits into from
Dec 18, 2018

Conversation

jespirit
Copy link
Collaborator

Fix typo with variable name. Just added _ underscore.

Changed this.alwaysShowTooltip to this._alwaysShowTooltip

else if(this.options.tooltip === 'always') {
this._showTooltip();
this._alwaysShowTooltip = true;
}

_hideTooltip: function() {
if (this._state.inDrag === false && this.alwaysShowTooltip !== true) {
this._removeClass(this.tooltip, 'in');
this._removeClass(this.tooltip_min, 'in');
this._removeClass(this.tooltip_max, 'in');
}
this._state.over = false;
},

Added a unit test.

Also there was a bug when options.tooltip was set to 'always' and the options.ticks_tooltip was set to true.

Pull Requests

Please accompany all pull requests with the following (where appropriate):

  • unit tests (we use Jasmine 2.x.x)
  • JSFiddle (or an equivalent such as CodePen, Plunker, etc) or screenshot/GIF with new feature or bug-fix
  • Link to original Github issue (if this is a bug-fix)
  • Passes CI-server checks (runs automated tests, JS source-code linting, etc..). To run these on your local machine, type grunt test in your Terminal within the bootstrap-slider repository directory

Copy link
Collaborator

@rovolution rovolution left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@jespirit jespirit merged commit 0e329d8 into seiyria:master Dec 18, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants