#160886981 Create /auth/signup , /auth/login endpoints #14
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add Database, Register users and store to db. Add /auth/signup, /auth/login endpoints [Delivers #160886981]
|
|
ooh yes, @Kasulejoseph thanks |
Kasulejoseph
reviewed
Oct 3, 2018
api/routes.py
Outdated
| access_token = create_access_token(identity=username) | ||
| return jsonify(access_token=access_token), status.HTTP_200_OK | ||
|
|
||
| # Protect a view with jwt_required, which requires a valid access token |
There was a problem hiding this comment.
In-line comments is also not recommended in PEP8 so avoid it
Modified /auth/login to check username and password during login [Delivers #160886981]
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
Have signup and login for the fast-food-fast API
Description of the task to be completed
POST /auth/signup
POST /auth/login
With those endpoints, a user can successfully create an account on fast-food-fast, the data is successfully stored in fast-food-fast db.
POST /auth/login - This endpoint at moment do tests with a username=test and password=test and generate an access token with jwt successfully.