Do not use Discount's internal header and structures #1
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sekimura
added a commit
that referenced
this pull request
Jan 25, 2012
Do not use Discount's internal header and structures
|
thanks a lot! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The
cstring.hheader and theDocument,ParagraphandLinestructures are meant for internal discount use and shouldn't be used externally (moreover given thatText::Markdown::Discountdoes not make much use of them). The opaqueMMIOTdata type should suffice.Not using them has the benefit of making
Text::Markdown::Discountbuildable without using the embedded copy of discount.This patch is applied to the Debian package for
Text::Markdown::Discount.Cheers