Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix error when updating checks via Pingdom API. #116

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

gfokkema
Copy link

Apparently pingdom checks now output additional params lastdownstart
and lastdownend which the api is unable to handle as arguments.

Solves the following error:

Traceback (most recent call last):
...
  File "/home/gerloffokkema/.local/lib/python3.8/site-packages/pypingdom/client.py", line 81, in update_check
    self.api.send(method='put', resource='checks', resource_id=check._id, data=data)
  File "/home/gerloffokkema/.local/lib/python3.8/site-packages/pypingdom/api.py", line 48, in send
    raise ApiError(response)
pypingdom.api.ApiError: pingdom.ApiError: HTTP `400 - Bad Request` returned with message, "Invalid parameter: lastdownend."

Apparently pingdom checks now output additional params `lastdownstart`
and `lastdownend` which the api is unable to handle as arguments.
@lawrencekoenig
Copy link

The Update you have created looks like the PR has failed due to a log failure. Can we have this retriggered?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants