Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Continous Benchmark #1392

Draft
wants to merge 64 commits into
base: dev
Choose a base branch
from
Draft

Continous Benchmark #1392

wants to merge 64 commits into from

Conversation

egecetin
Copy link
Collaborator

@egecetin egecetin commented May 11, 2024

Automatically generate performance benchmark information for website using Google Benchmark

Copy link

codecov bot commented Aug 30, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 82.93%. Comparing base (a600a70) to head (d6e90c0).
Report is 4 commits behind head on dev.

Additional details and impacted files
@@            Coverage Diff             @@
##              dev    #1392      +/-   ##
==========================================
- Coverage   82.94%   82.93%   -0.02%     
==========================================
  Files         273      273              
  Lines       46353    46353              
  Branches     9642     9472     -170     
==========================================
- Hits        38446    38441       -5     
- Misses       7280     7311      +31     
+ Partials      627      601      -26     
Flag Coverage Δ
fedora39 74.55% <ø> (-0.02%) ⬇️
macos-12 80.89% <ø> (-0.01%) ⬇️
macos-13 80.31% <ø> (-0.01%) ⬇️
macos-14 80.22% <ø> (-0.02%) ⬇️
mingw32 71.42% <ø> (-0.04%) ⬇️
mingw64 71.42% <ø> (-0.03%) ⬇️
npcap 84.88% <ø> (-0.03%) ⬇️
rhel94 74.31% <ø> (-0.03%) ⬇️
ubuntu2004 57.90% <ø> (+<0.01%) ⬆️
ubuntu2004-zstd 58.05% <ø> (+<0.01%) ⬆️
ubuntu2204 74.23% <ø> (-0.05%) ⬇️
ubuntu2204-icpx 58.43% <ø> (-0.04%) ⬇️
ubuntu2404 74.52% <ø> (-0.01%) ⬇️
unittest 82.93% <ø> (-0.02%) ⬇️
windows-2019 84.92% <ø> (-0.03%) ⬇️
windows-2022 84.93% <ø> (-0.03%) ⬇️
winpcap 84.90% <ø> (-0.02%) ⬇️
xdp 49.29% <ø> (-0.01%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@tigercosmos
Copy link
Collaborator

Where can I see the benchmark result?

@egecetin
Copy link
Collaborator Author

egecetin commented Aug 31, 2024

@tigercosmos Check "Run benchmark" step https://github.com/seladb/PcapPlusPlus/actions/runs/10644856460/job/29510043289

Approx. 10Gbps parsing, 1Gbps crafting performance in GitHub CI (just looking bytes per sec). Also items per sec is a good indicator which can we tabulate as for mean packet sizes (For example, if avg packet length 64, 512, 1024, 1500 etc -> size* items per sec *8

@tigercosmos
Copy link
Collaborator

Will it show a warning if the benchmark performance decreases too much? Otherwise, people will not click into the CI and check the result.

@egecetin
Copy link
Collaborator Author

egecetin commented Sep 1, 2024

@tigercosmos Actually my aim is to generate and update the benchmark results automatically. I enabled PR runs for just testing. I'll disable it when the work is done, and the runs will be only from master or dev. Because benchmark results can be very flaky without a dedicated machine/runner unfortunately. This workflow and integration with Google benchmark are just for easier benchmarking in local PCs and to give an idea about to performance in PcapPlusPlus website (since current benchmark really old)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Update benchmark
2 participants