Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[pcapplusplus] Reduce test package #2

Merged

Conversation

uilianries
Copy link

The test package is mainly focused to validate the generated package, if it includes headers, libraries, license and can link without errors. Testing features is not needed and only adds more complexity. Said that, pcap is not needed to validate pcapplusplus package.

Also, test_package and test_v1_package are different, there are illustrated on https://github.com/conan-io/conan-center-index/tree/master/docs/package_templates/cmake_package/all but basically, each one is focused on Conan 1.x and 2.x with backward compatibility.

This PR simplifies a lot the current test package and should end the headache involving testing on Windows.

Signed-off-by: Uilian Ries <uilianries@gmail.com>
@seladb seladb merged commit 63c894f into seladb:pcapplusplus-v22.11-2 Jan 21, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
2 participants