Stop bubbling up events when removing a choice #3853
Closed
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #3209
I've tried also changing the original click event listener to exclude
.select2-selection__choice__remove
child, but I didn't figure how.Anyway preventing event to bubble up to main container seems to be cleaner solution.
We are using Select2 as a filter in SPA when changing options triggers re-rendering view with filtered items. When options is removed, options container opens up and when view re-renders options container jumps out to upper left corner and detaches itself from main container.
By the way: what about a new release?