Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added i18n: Punjabi language #5831

Merged
merged 7 commits into from
Apr 19, 2020
Merged

Added i18n: Punjabi language #5831

merged 7 commits into from
Apr 19, 2020

Conversation

adsingh14
Copy link
Contributor

@adsingh14 adsingh14 commented Apr 18, 2020

This pull request includes a

  • Translation

The following changes were made

  • Added new i18n Punjabi language file, pa.js, in src/js/select2/i18n/

adsingh14 and others added 7 commits April 18, 2020 18:04
Typo missing semi-colon fixed.
Rephrasing sentences for making sentence acceptable by 'Linter'.
Fixing code according to 'CI / Linting' test.
Rephrase sentence for passing 'CI/Linting' test.
Renamed file name ( from **pb** to **pa** ) according to i18n standard.
@kevin-brown
Copy link
Member

kevin-brown commented Apr 19, 2020

Hi there and thanks for contributing this translation to Select2. Unfortunately it looks like the pb language code was used for this translation, which doesn't align with the ISO 639 language code of pa which was assigned to the Punjabi language. If the file could be renamed to pa.js that would make it easier for us when we come around to merging this in for the upcoming release.

Actually it looks like you renamed the file after the fact, something I missed when doing the initial review of this last night.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants