Fix for "change" event being fired when value doesn't change (#175).

selectize · Nov 3, 2013 · 54cc373 · 54cc373
1 parent 25425e7
commit 54cc373
Show file tree

Hide file tree

Showing 2 changed files with 17 additions and 2 deletions.
diff --git a/src/selectize.js b/src/selectize.js
@@ -1226,10 +1226,10 @@ $.extend(Selectize.prototype, {
 			var i, active, options, value_next;
 			value = hash_key(value);
 
-			if (inputMode === 'single') self.clear();
-			if (inputMode === 'multi' && self.isFull()) return;
 			if (self.items.indexOf(value) !== -1) return;
 			if (!self.options.hasOwnProperty(value)) return;
+			if (inputMode === 'single') self.clear();
+			if (inputMode === 'multi' && self.isFull()) return;
 
 			$item = $(self.render('item', self.options[value]));
 			self.items.splice(self.caretPos, 0, value);

diff --git a/test/events.js b/test/events.js
@@ -20,6 +20,21 @@ describe('Events', function() {
 			});
 			test.selectize.setValue('c');
 		});
+		it('should not be triggered when the selected item has not changed', function(done) {
+			var test = setup_test('<select><option value="a" selected="selected">a</option></select>');
+
+			var counter = 0;
+			test.$select.on('change', function() { counter++; });
+
+			Syn.click(test.selectize.$control).delay(0, function() {
+				Syn
+					.click($('[data-value="a"]', test.selectize.$dropdown))
+					.delay(0, function() {
+						expect(counter).to.be.equal(0);
+						done();
+					});
+			});
+		});
 	});
 
 	describe('item_add', function() {