Allow render functions in options to return DOM. #617
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Looks like childNodes is supported better across browsers.
|
@brianreavis what's stoping this from getting merged? Maybe we can help? |
|
@brianreavis Any updates? +1 |
|
+1 |
1 similar comment
|
+1 |
|
@brianreavis Can we please get some attention on this PR? Is there anything preventing you from merging this in? There is a a fairly large group of people wanting this PR to go in because there is an Ember addon depending on this PR. |
|
+1 |
|
If there's anything left to do, please let me know. If this feature isn't something you want to support, feel free to close this PR. |
|
+1 |
|
Great PR, thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR allows the functions in the render options "option", "item", "option_create", "optgroup_header", "optgroup" to return DOM nodes instead of plain strings.
This should come in handy, in contexts where we do not have strings but DOM, like in ember.js.
See:
https://github.com/miguelcobain/ember-selectize/blob/master/src/ember.selectize.js#L476
which caused
emberjs/ember.js#5534
I have no idea what I'm going to break with these changes :)