[server] Fix NPE in ViewHierarchyAnalyzer #929
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Summary: We are seeing cases where we're querying native elements, but there is no current activity. Previously this would result in a `NullPointerException` in the `ViewHierarchyAnalyzer`. This changes fixes the exception and adds a fallback when looking for resources: - added a check to see if the activity is `null` - if that's the case, try to get the resources from the passed view - before getting trying to get the resource name, check if the resources returned are non null (we've seen that case as well) Test Plan: Ran our internal e2e tests against selendroid with this patch.
|
looks good to me, feel free to merge after travis comes back green |
|
More green! 🎉 |
asm89
added a commit
that referenced
this pull request
Jun 30, 2015
[server] Fix NPE in ViewHierarchyAnalyzer
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary: We are seeing cases where we're querying native elements, but
there is no current activity. Previously this would result in a
NullPointerExceptionin theViewHierarchyAnalyzer. This changesfixes the exception and adds a fallback when looking for resources:
nullreturned are non null (we've seen that case as well)
Test Plan: Ran our internal e2e tests against selendroid with this
patch.