Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Safari webdriver starts with only one capability. All other capabilities are not merged correctly #1836

Closed
pavelkrakhalev2 opened this issue Jun 3, 2022 · 0 comments · Fixed by #1841
Assignees
Milestone

Comments

@pavelkrakhalev2
Copy link

The problem

Unable to start Safari webdriver on browserStack

Details

When we create a webdriver instance for Safari driver, capabilities are not merged correctly, as result we have only one capability - browser name, but to start browserStack session we need to pass all commonCapabilities.

This happens because we return wrong SafariOption object from createCapabilities method of class SafariDriverFactory.
image
options.merge creates new instance of SafariOptions, so we need to return result of options.merge instead of old options object

Tell us about your environment

  • Selenide Version: 6.5.0

Code To Reproduce Issue

Configuration.browser = Browsers.SAFARI;
Configuration.browserCapabilities = capabilities;
Configuration.remote = browserStackURL.toString();
open();
@asolntsev asolntsev added this to the 6.6.0 milestone Jun 3, 2022
asolntsev added a commit that referenced this issue Jun 6, 2022
@asolntsev asolntsev self-assigned this Jun 6, 2022
asolntsev added a commit that referenced this issue Jun 6, 2022
asolntsev added a commit that referenced this issue Jun 6, 2022
asolntsev added a commit that referenced this issue Jun 6, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants