New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Selenide cannot download files with cyrillic (and probably any UTF-8) name #688

Closed
asolntsev opened this Issue Feb 1, 2018 · 1 comment

Comments

Projects
None yet
2 participants
@asolntsev
Contributor

asolntsev commented Feb 1, 2018

The problem

Given a file with cyrillic letters, Selenide downloads it, but with a wrong name.

Details

  1. Call method File file = $("a").download();
  2. The downloaded file should contain cyrilic letters (like файл-с-русским-названием.txt)
  3. But Selenide creates a file with a wrong name in which all cyrillic letters are replaced with spaces (like - - - .txt)

@asolntsev asolntsev self-assigned this Feb 1, 2018

@asolntsev asolntsev added the bug 🐛 label Feb 1, 2018

@asolntsev asolntsev added this to the 4.11 milestone Feb 1, 2018

@vinogradoff vinogradoff changed the title from Selenide cannot download files with cyrillic name to Selenide cannot download files with cyrillic (and probably any UTF-8) name Feb 8, 2018

asolntsev added a commit that referenced this issue Mar 11, 2018

#688 properly decode "Content-Disposition" http header
.. to extract correct file name in cyrillic

@asolntsev asolntsev added the has pr label Mar 11, 2018

asolntsev added a commit that referenced this issue Mar 11, 2018

asolntsev added a commit that referenced this issue Mar 12, 2018

@rosolko

This comment has been minimized.

Collaborator

rosolko commented Mar 22, 2018

Closed via #689

@rosolko rosolko closed this Mar 22, 2018

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment