Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix the Jenkins integration issue #1049

Merged
merged 3 commits into from
Feb 5, 2020
Merged

Fix the Jenkins integration issue #1049

merged 3 commits into from
Feb 5, 2020

Conversation

topikachu
Copy link
Contributor

Proposed changes

Fix the Jenkins integration issue

  1. Read BUILD_URL from both system property and environment variable
  2. Calculate the report relative path when resolving report URL.

Checklist

  • Checkstyle and unit tests pass locally with my changes by running gradle check chrome_headless firefox_headless command
  • I have added tests that prove my fix is effective or that my feature works
    It's about Jenkins integration. No test.
  • I have added necessary documentation (if appropriate)
    Fix an issue. No document.

Fix the Jenkins integration issue
72221fe 
1. Read BUILD_URL from both system property and environment variable
2. Calculate the report relative path when resolve report URL.
@asolntsev asolntsev self-assigned this Feb 4, 2020
@asolntsev asolntsev added this to the 5.6.2 milestone Feb 4, 2020
@topikachu topikachu mentioned this pull request Feb 4, 2020
Closed
3 tasks
@asolntsev asolntsev self-requested a review February 4, 2020 07:31
@topikachu
Copy link
Contributor Author

topikachu commented Feb 4, 2020 •
edited
Loading

@asolntsev This PR is refined

  1. I think it's better to enable the CI report until BUILD_URL is set explicitly as old behavior.
  2. Fix the path issue on Windows slaves.

1. Go back to the old behavior that requires 'BUILD_URL' system prope…
c542f39 
…rty.

2. Fix the path issue when running on windows slave.
@asolntsev asolntsev merged commit 6c19afd into selenide:master Feb 5, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@rosolko rosolko rosolko left review comments

@asolntsev asolntsev asolntsev approved these changes

Assignees

@asolntsev asolntsev

Labels
None yet
Projects
None yet
Milestone
5.7.0
Development

Successfully merging this pull request may close these issues.
3 participants
@topikachu @asolntsev @rosolko