fix 'emptyMethod' folder name #1138
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
asolntsev
requested changes
Apr 29, 2020
There was a problem hiding this comment.
@dengayevskiy-sb Looks good!
You only need to fix checkstyle errors. See https://travis-ci.org/github/selenide/selenide/jobs/681169188 : some lines got too long now.
dengayevskiy-sb
force-pushed
the
fix-emptymethod-report-folder
branch
from
a7ce7e6
to
d90d0cf
Compare
asolntsev
approved these changes
Apr 30, 2020
|
@dengayevskiy-sb Thank you! Merged. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Proposed changes
If Selenide is used with JUnit 5 all reports and screenshots about failed tests will be stored at '../UserRegistrationTests/emptyMethod/1588171516595.0.png'. It is inconvenient, because everything goes to the same folder. With this fix emptyMethod will be replaces with the actual test method name createUserAndLogin, like it is working in Selenide + JUnit 4.
Checklist
gradlew check chrome_headless firefox_headlesscommand