Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fixes #1298 - href condition for encoded vals #1299

Merged
merged 2 commits into from
Oct 30, 2020
Merged

fixes #1298 - href condition for encoded vals #1299

merged 2 commits into from
Oct 30, 2020

Conversation

rerednaw
Copy link
Contributor

Checklist

  • Checkstyle and unit tests are passed locally with my changes by running gradlew check chrome_headless firefox_headless command
  • I have added tests that prove my fix is effective or that my feature works
  • I have added necessary documentation (if appropriate)

@rerednaw rerednaw mentioned this pull request Oct 30, 2020
Closed
@asolntsev asolntsev self-requested a review October 30, 2020 22:56
@asolntsev asolntsev self-assigned this Oct 30, 2020
@asolntsev asolntsev added this to the 5.16.0 milestone Oct 30, 2020
@asolntsev asolntsev merged commit fd38527 into selenide:master Oct 30, 2020
@asolntsev asolntsev linked an issue Nov 20, 2020 that may be closed by this pull request
Condition.href fails if expected value contains encoded characters #1298
Closed
akoira pushed a commit to akoira/selenide that referenced this pull request Jun 13, 2021
@rerednaw @AndreyKoyro
fixes selenide#1298 - href condition for encoded vals (selenide#1299)
92e34a3 
* selenide#1298 fix href condition for encoded vals

* selenide#1298 integration test
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@asolntsev asolntsev asolntsev approved these changes

Assignees

@asolntsev asolntsev

Labels
bug 🐛
Projects
None yet
Milestone
5.16.0
Development

Successfully merging this pull request may close these issues.

Condition.href fails if expected value contains encoded characters
2 participants
@rerednaw @asolntsev