#1571 use standard method WebDriver.getScreenshotAs() to get the element #1576
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
... to get a screenshot of a single element. it seems to work better (than our previous home-made code) on Retina display. NB! I had to change parameter type from WebElement to SelenideElement because WebElement cannot be found before switching to frame, that's why it need to be (lazy-loaded) SelenideElement.
now we check the image more precisely: * check the color of border (red for all divs) * check the color of body (own color for every div) * allow slightly varying colors in different browsers
asolntsev
force-pushed
the
fix-element-screenshot-on-mac
branch
from
d44e283
to
f002fe1
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fix fo #1571