Add support for custom duration in switchTo().frame()
#1722
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
donesvad
force-pushed
the
add-switch-to-frame-with-custom-duration
branch
2 times, most recently
from
8c5b6f7
to
46768d4
Compare
asolntsev
requested changes
Feb 4, 2022
| * @param duration the timeout duration. It overrides default Config.timeout() | ||
| */ | ||
| @Nonnull | ||
| public WebDriver frame(int index, Duration duration) { |
There was a problem hiding this comment.
rename parameter duration to timeout.
| * @param duration the timeout duration. It overrides default Config.timeout() | ||
| */ | ||
| @Nonnull | ||
| public WebDriver frame(String nameOrId, Duration duration) { |
|
|
||
| @AfterEach | ||
| void tearDown() { | ||
| driver().close(); |
There was a problem hiding this comment.
we don't need to close the browser after every test: it makes tests much slower.
donesvad
force-pushed
the
add-switch-to-frame-with-custom-duration
branch
from
46768d4
to
8c22f03
Compare
alexandrter
approved these changes
Feb 4, 2022
asolntsev
approved these changes
Feb 4, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Proposed changes
Add support for custom duration in
switchTo().frame()Checklist
gradlew check chrome_headless firefox_headlesscommand