#2087 support @As annotation for page object fields

[asolntsev]

... not annotated by @findby, but initialized with $ or $$.

This pull request allows to declare page object fields with $ or $$, but mark them with annotation @As:

static class PageObject {
    @As("Dollar header")
    SelenideElement header4 = $("h1");

    @As("Dollar collection")
    ElementsCollection header5 = $$("h2");
}

@PramodKumarYadav

[PramodKumarYadav]

Looks good to me 🙌!

Only remark: The if-else block in the initFields method have grown a bit lengthy but I dont fully understand the implementation to comment if this could be optimised further (or not).

Considering that the selenide elements block of code only use page and proxyIn parameters to derive everything it needs, maybe there is way to break our implementation into further smaller methods that explain our intention here better? However considering I am not able to provide a better refactor alternative at this moment, this is just a passing thought that I wanted to share with you (in case if you can think of an alternative way - or maybe this is already the best alternative).

For now, thanks a ton for making this feature available on such a short notice! I appreciate it :) .

[sonarcloud]

Kudos, SonarCloud Quality Gate passed!   

0 Bugs
0 Vulnerabilities
0 Security Hotspots
2 Code Smells

No Coverage information
0.0% Duplication

[asolntsev]

@PramodKumarYadav Good point, I refactored this method: split it to smaller methods.

There is always a room for improvement. :)

[PramodKumarYadav]

The refactored code is super clear 🙌. Thanks @asolntsev 😊.