fix usages of aliases in reports #2702
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
I discovered that in many cases, *.as("The alias") is not really used in reports.
P.S. Unit-tests CollectionElementTest and CollectionElementByConditionTest should be converted to integration tests. Currently they test the same things they mock.
I discovered that actual vs expected value looked the same in IDEA, e.g. "Element should not exist" Actual: exists Expected: exist
asolntsev
force-pushed
the
fix/usages-of-aliases-in-reports
branch
from
d013308
to
e64b9d5
Compare
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I discovered that in many cases, *.as("The alias") is not really used in reports.