Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix usages of aliases in reports #2702

Merged
merged 2 commits into from
Mar 30, 2024
Merged

fix usages of aliases in reports #2702

merged 2 commits into from
Mar 30, 2024

Commits on Mar 30, 2024

  1. fix usages of aliases in reports 

    I discovered that in many cases, *.as("The alias") is not really used in reports.

P.S. Unit-tests CollectionElementTest and CollectionElementByConditionTest should be converted to integration tests. Currently they test the same things they mock.
    @asolntsev
    asolntsev committed Mar 30, 2024
    Configuration menu
    Copy the full SHA
    e58b68b View commit details
    Browse the repository at this point in the history

  2. fix the actual value of assertion error in case of $.shouldNot(*) 

    I discovered that actual vs expected value looked the same in IDEA, e.g.
"Element should not exist"
Actual: exists
Expected: exist
    @asolntsev
    asolntsev committed Mar 30, 2024
    Configuration menu
    Copy the full SHA
    e64b9d5 View commit details
    Browse the repository at this point in the history