Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

introduce setValueChangeEvent option #718

Merged
merged 4 commits into from
Apr 25, 2018
Merged
Show file tree
Hide file tree
Changes from 3 commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion gradle/tests.gradle
Original file line number Diff line number Diff line change
Expand Up @@ -32,7 +32,7 @@ task safari(type: Test) {
task htmlunit(type: Test) {
systemProperties['selenide.browser'] = 'htmlunit'
include 'integration/**/*'
exclude 'com/codeborne/selenide/**/*'
exclude 'com/codeborne/selenide/**/*', 'integration/*PageWithoutJQuery*'
Copy link
Member

@BorisOsipov BorisOsipov Apr 24, 2018

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@MikeShysh please, revert this and use assumeFalse(isHtmlUnit()); in test you would like to skip for htmlunit

}

task phantomjs(type: Test) {
Expand Down
12 changes: 12 additions & 0 deletions src/main/java/com/codeborne/selenide/Configuration.java
Original file line number Diff line number Diff line change
Expand Up @@ -301,6 +301,18 @@ private static String getJenkinsReportsUrl() {
*/
public static boolean versatileSetValue = Boolean.parseBoolean(System.getProperty("selenide.versatileSetValue", "false"));

/**
* If set to true, 'setValue' and 'val' methods of SelenideElement trigger changeEvent after main manipulations.
*
* Firing change event is not natural and could lead to unpredictable results. Browser fires this event automatically
* according to web driver actions. Recommended behaviour is to disable this option.
* Make its true by default for backward compatibility.
*
* Can be configured either programmatically or by system property "-Dselenide.setValueChangeEvent=true".
* Default value: true
*/
public static boolean setValueChangeEvent = Boolean.parseBoolean(System.getProperty("selenide.setValueChangeEvent", "true"));

/**
* Choose how Selenide should retrieve web elements: using default CSS or Sizzle (CSS3)
*/
Expand Down
5 changes: 4 additions & 1 deletion src/main/java/com/codeborne/selenide/commands/Append.java
Original file line number Diff line number Diff line change
Expand Up @@ -5,14 +5,17 @@
import com.codeborne.selenide.impl.WebElementSource;
import org.openqa.selenium.WebElement;

import static com.codeborne.selenide.Configuration.setValueChangeEvent;
import static com.codeborne.selenide.impl.Events.events;

public class Append implements Command<WebElement> {
@Override
public WebElement execute(SelenideElement proxy, WebElementSource locator, Object[] args) {
WebElement input = locator.getWebElement();
input.sendKeys((String) args[0]);
events.fireChangeEvent(input);
if (setValueChangeEvent) {
events.fireChangeEvent(input);
}
return proxy;
}
}
5 changes: 4 additions & 1 deletion src/main/java/com/codeborne/selenide/commands/SetValue.java
Original file line number Diff line number Diff line change
Expand Up @@ -8,6 +8,7 @@
import org.openqa.selenium.WebElement;

import static com.codeborne.selenide.Configuration.fastSetValue;
import static com.codeborne.selenide.Configuration.setValueChangeEvent;
import static com.codeborne.selenide.Selenide.executeJavaScript;
import static com.codeborne.selenide.impl.Events.events;

Expand Down Expand Up @@ -55,7 +56,9 @@ private void setValueForTextInput(WebElement element, String text) {
} else {
element.clear();
element.sendKeys(text);
events.fireChangeEvent(element);
if (setValueChangeEvent) {
events.fireChangeEvent(element);
}
}
}

Expand Down
19 changes: 19 additions & 0 deletions src/test/java/integration/PageWithJQuery.java
Original file line number Diff line number Diff line change
@@ -1,8 +1,10 @@
package integration;

import org.junit.Before;
import org.junit.After;
import org.junit.Test;
import org.openqa.selenium.By;
import com.codeborne.selenide.Configuration;

import static com.codeborne.selenide.Condition.text;
import static com.codeborne.selenide.Selenide.$;
Expand All @@ -24,9 +26,26 @@ public void setValueTriggersOnChangeEvent() {
$("h2").shouldHave(text("john bon-jovi"));
}

@Test
public void setValueDoesNotTriggerOnChangeEvent() {
Configuration.setValueChangeEvent = false;
$("#username").setValue("john");
$("h2").shouldNotHave(text("john"));

$("#username").append(" ");
$("#username").append("bon-jovi");

$("h2").shouldNotHave(text("john bon-jovi"));
}

@Test
public void selectByXpath() {
$(By.xpath("html/body/div[2]/form[1]/fieldset[1]//input[@name='username']")).val("Underwood");
$(By.xpath("/html//h2[1]")).shouldHave(text("Underwood"));
}

@After
public void tearDown() {
Configuration.setValueChangeEvent = true;
}
}
22 changes: 21 additions & 1 deletion src/test/java/integration/PageWithoutJQuery.java
Original file line number Diff line number Diff line change
@@ -1,14 +1,16 @@
package integration;

import org.junit.Before;
import org.junit.After;
import org.junit.Test;
import com.codeborne.selenide.Configuration;

import static com.codeborne.selenide.Condition.text;
import static com.codeborne.selenide.Selenide.$;

public class PageWithoutJQuery extends IntegrationTest {
@Before
public void openTestPageWithJQuery() {
public void openTestPageWithOutJQuery() {
openFile("page_with_selects_without_jquery.html");
}

Expand All @@ -22,4 +24,22 @@ public void setValueTriggersOnChangeEvent() {

$("#username-mirror").shouldHave(text("john bon-jovi"));
}

@Test
public void setValueDoesNotTriggerOnChangeEvent() {
Configuration.setValueChangeEvent = false;

$("#username").setValue("john");
$("#username-mirror").shouldHave(text("_"));

$("#username").append(" ");
$("#username").append("bon-jovi");

$("#username-mirror").shouldHave(text("_"));
}

@After
public void tearDown() {
Configuration.setValueChangeEvent = true;
}
}