Fix screenshots in maven #972
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
starting from some version, Maven uses `e.getClass()+e.getMessage()` instead of `e.toString()`. But Selenide added screenshot and timeout in `UIAssertionError.toString()`. Had to refactor many unit-tests that heavily depended on format of error message.
|
Thanks! Releasing Selenide 5.3.1 |
asolntsev
added a commit
that referenced
this pull request
Oct 13, 2019
instead of long message `com.codeborne.selenide.ex.ElementNotFound: Element not found {#customerDashboardButton}`,
just use shorter message `Element not found {#customerDashboardButton}`
* it improves changes done in PR #972 for issue #234
* Maven users with latest surefire plugin will still see the long error message
3 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #234
Checklist
gradle check chrome htmlunitcommand