Make owner optional for runners and jobs command(s)

Signed-off-by: Alex Ellis (OpenFaaS Ltd) <alexellis2@gmail.com>
self-actuated · Aug 15, 2023 · bf1af0b · bf1af0b
1 parent 4b0bc93
commit bf1af0b
Show file tree

Hide file tree

Showing 3 changed files with 8 additions and 10 deletions.
diff --git a/cmd/jobs.go b/cmd/jobs.go
@@ -56,10 +56,6 @@ func runJobsE(cmd *cobra.Command, args []string) error {
 		return err
 	}
 
-	if len(owner) == 0 {
-		return fmt.Errorf("owner is required")
-	}
-
 	if len(pat) == 0 {
 		return fmt.Errorf("pat is required")
 	}

diff --git a/cmd/runners.go b/cmd/runners.go
@@ -57,10 +57,6 @@ func runRunnersE(cmd *cobra.Command, args []string) error {
 		return err
 	}
 
-	if len(owner) == 0 {
-		return fmt.Errorf("owner is required")
-	}
-
 	if len(pat) == 0 {
 		return fmt.Errorf("pat is required")
 	}

diff --git a/pkg/client.go b/pkg/client.go
@@ -31,7 +31,10 @@ func (c *Client) ListJobs(patStr string, owner string, staff bool, json bool) (s
 		q.Set("staff", "1")
 	}
 
-	q.Set("owners", owner)
+	if len(owner) > 0 {
+		q.Set("owners", owner)
+	}
+
 	u.RawQuery = q.Encode()
 
 	req, err := http.NewRequest(http.MethodGet, u.String(), nil)
@@ -82,7 +85,10 @@ func (c *Client) ListRunners(patStr string, owner string, staff bool, json bool)
 		q.Set("staff", "1")
 	}
 
-	q.Set("owner", owner)
+	if len(owner) > 0 {
+		q.Set("owner", owner)
+	}
+
 	u.RawQuery = q.Encode()
 
 	req, err := http.NewRequest(http.MethodGet, u.String(), nil)