Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Ci issues and pr templates #293

Merged
merged 3 commits into from
Nov 27, 2023
Merged

Conversation

qlrd
Copy link
Contributor

@qlrd qlrd commented Nov 25, 2023

Added some templates for adding new tagged issues and PRs. Useful for:

  • When a developer or krux user click to create a new issue, it will open a new page with a stylished issue with automatic tags like bug, enhancement or help_wanted (see this example)

  • When a developer create a new PR, it will open an already created text with selectors (about which change he/she made) and a Description space to talk about it.

Copy link

codecov bot commented Nov 25, 2023

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (a304206) 92.24% compared to head (99ce050) 92.24%.

❗ Current head 99ce050 differs from pull request most recent head cf4aa34. Consider uploading reports for the commit cf4aa34 to get more accurate results

Additional details and impacted files
@@           Coverage Diff           @@
##             main     #293   +/-   ##
=======================================
  Coverage   92.24%   92.24%           
=======================================
  Files          42       42           
  Lines        5290     5290           
=======================================
  Hits         4880     4880           
  Misses        410      410           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

odudex
odudex previously approved these changes Nov 27, 2023
Copy link
Member

@odudex odudex left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

All good!

@odudex odudex dismissed their stale review November 27, 2023 12:55

Saw a typo

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

"Confuse" becomes "Confused". But, this sentence looks more like a question instead of a affirmation. Maybe I would change to something like. "Help needed to use a feature, perform or understand a procedure"

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

done

@odudex odudex merged commit 7add64a into selfcustody:main Nov 27, 2023
5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants