Example of adding app as a mobile app integration #5
Conversation
…evice is already registered
|
@kylepotts can you refactor to use https://crates.io/crates/ha_api |
| url = "2.1.1" | ||
| tungstenite = "0.11.1" | ||
| percent-encoding = "2.1.0" | ||
| ha_api = { git = "https://github.com/kylepotts/ha_api", branch = "kylep-add-as-mobile-app"} |
There was a problem hiding this comment.
Would be nice for this to represent the actual upstream once the PR is merged
There was a problem hiding this comment.
I think that it is find for rapid prototyping. In the future we are going to require that changes be accepted in the library before they merged here
There was a problem hiding this comment.
My personal preference would be that every commit, CI would generate a snapshot version of the library which the user could point to.
I imagine the process would be as such
1). PR against ha_api repo
2). PR against this repo pointing to snapshot version generated in 1
3). PR in 1 is merged, non snapshot version of the library is created
4) PR in 2 is updated with the non snapshot version
There was a problem hiding this comment.
I don't love pushing to crates.io on every commit
There was a problem hiding this comment.
That is fine but we should standardize on some process. I'm fine with pointing to the git repo while were doing active development.
There was a problem hiding this comment.
I see it going like this. If you are making a change in halcyon that requires changes to api library. you will need to
- Open a PR on homeassistant-rs
- Have PR merged on homeassistent-rs
- Open PR on halcyon
- Have PR merged on halcyon
OR
- Open a PR on homeassistant-rs and hyalcyon (with api pionting at github branch)
- Have PR merged on homeassistent-rs
- Change api version to point at the new version pushed when homeassitant-rs PR is merged
- Have PR merged on halcyon
In general treating the two repos as two projects
No description provided.