Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Rewrite libselinux python restorecon method using selinux_restorecon() #29

Closed
stephensmalley opened this issue Nov 17, 2016 · 0 comments
Closed

Rewrite libselinux python restorecon method using selinux_restorecon() #29

stephensmalley opened this issue Nov 17, 2016 · 0 comments

Comments

@stephensmalley
Copy link
Member

Long ago, Dan added a restorecon method to the libselinux swig python bindings (selinuxswig_python.i). Since there was no libselinux restorecon implementation at the time, he had it call matchpathcon(), which is deprecated in favor of selabel_lookup(), and implemented his own tree walk logic. Reimplement it using the selinux_restorecon() function now that it exists
@stephensmalley stephensmalley mentioned this issue Dec 20, 2016
Closed
bachradsusi added a commit to bachradsusi/SELinuxProject-selinux that referenced this issue Dec 22, 2016
@bachradsusi
libselinux: Rewrite restorecon() python method
6c7bc7b 
When the restorecon method was added to the libselinux swig python
bindings, there was no libselinux restorecon implementation and it
he had to call matchpathcon() which is deprecated in favor of
selabel_lookup().

The new restorecon method uses selinux_restorecon method from libselinux
and which is exported by the previous commit.

SELinuxProject#29

Fixes:
>>> selinux.restorecon('/var/lib', recursive=True)
Traceback (most recent call last):
  File "/usr/lib64/python3.5/site-packages/selinux/__init__.py", line 114, in restorecon
    status, context = matchpathcon(path, mode)
FileNotFoundError: [Errno 2] No such file or directory

Signed-off-by: Petr Lautrbach <plautrba@redhat.com>
stephensmalley pushed a commit that referenced this issue Jan 9, 2017
@bachradsusi @stephensmalley
libselinux: Rewrite restorecon() python method
14f0709 
When the restorecon method was added to the libselinux swig python
bindings, there was no libselinux restorecon implementation and it
he had to call matchpathcon() which is deprecated in favor of
selabel_lookup().

The new restorecon method uses selinux_restorecon method from libselinux
and which is exported by the previous commit.

#29

Fixes:
>>> selinux.restorecon('/var/lib', recursive=True)
Traceback (most recent call last):
  File "/usr/lib64/python3.5/site-packages/selinux/__init__.py", line 114, in restorecon
    status, context = matchpathcon(path, mode)
FileNotFoundError: [Errno 2] No such file or directory

Signed-off-by: Petr Lautrbach <plautrba@redhat.com>
bachradsusi added a commit to fedora-selinux/selinux that referenced this issue Jan 11, 2017
@bachradsusi
libselinux: Rewrite restorecon() python method
3dcc894 
When the restorecon method was added to the libselinux swig python
bindings, there was no libselinux restorecon implementation and it
he had to call matchpathcon() which is deprecated in favor of
selabel_lookup().

The new restorecon method uses selinux_restorecon method from libselinux
and which is exported by the previous commit.

SELinuxProject/selinux#29

Fixes:
>>> selinux.restorecon('/var/lib', recursive=True)
Traceback (most recent call last):
  File "/usr/lib64/python3.5/site-packages/selinux/__init__.py", line 114, in restorecon
    status, context = matchpathcon(path, mode)
FileNotFoundError: [Errno 2] No such file or directory

Signed-off-by: Petr Lautrbach <plautrba@redhat.com>
(cherry picked from SELinuxProject commit 14f0709)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@stephensmalley