Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

replace custom throttling code with @octokit/plugin-throttling #299

Closed
gr2m opened this issue Nov 13, 2020 · 2 comments · Fixed by #487
Closed

replace custom throttling code with @octokit/plugin-throttling #299

gr2m opened this issue Nov 13, 2020 · 2 comments · Fixed by #487
Labels
released

Comments

@gr2m
Copy link
Member

gr2m commented Nov 13, 2020 •
edited

as part of that, enable testing in Mac OS and Windows which currently fail because of flaky tests of the throttling code:
https://github.com/semantic-release/github/pull/298/checks?check_run_id=1397908452
gr2m added a commit that referenced this issue Nov 13, 2020
@gr2m
test: stop testing on Mac OS until #299 is resolved
634168a
@gr2m gr2m mentioned this issue Jan 10, 2022
Open
@oscard0m oscard0m mentioned this issue Mar 27, 2022
Open
@oscard0m
Copy link
Contributor

I'm going to draft a PR on this but I will need some guidance since it's my first contribution to semantic-release

@oscard0m oscard0m mentioned this issue Mar 27, 2022
Closed
achingbrain added a commit to achingbrain/github that referenced this issue Apr 8, 2022
@achingbrain
fix: use retry and throttle octokit plugins
fa3e386 
Refactors the client to use [@octokit/plugin-retry](https://www.npmjs.com/package/@octokit/plugin-retry)
and [@octokit/plugin-throttling](https://www.npmjs.com/package/@octokit/plugin-throttling)
as GitHub occasionally changes it's API and these plugins can abstract
those changes away from this module.

- Removes `lib/definitions/rate-limit.js`
- Adds `lib/definitions/retry.js` and `lib/definitions/throttle.js` to handle retry/throttle settings
- Updates tests to be more like GitHub (returing the correct rate limit response headers, etc)

Fixes semantic-release#299 and semantic-release/semantic-release#2204
See also semantic-release#480 and semantic-release#378
@achingbrain achingbrain mentioned this issue Apr 8, 2022
Merged
@ryanbas21 ryanbas21 mentioned this issue Apr 12, 2023
Closed
@gr2m gr2m closed this as completed in #487 May 27, 2023
@github-actions
Copy link

🎉 This issue has been resolved in version 8.0.8 🎉

The release is available on:

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
released
Projects
None yet
Milestone
No milestone
2 participants
@gr2m @oscard0m